Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18572 )
Change subject: [Tools] Rebuild master according to part of tables not all tables ...................................................................... Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/master/sys_catalog.h File src/kudu/master/sys_catalog.h: http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/master/sys_catalog.h@415 PS10, Line 415: SimpleTableVisitor simpleTableLoader_; nit: use snake case. http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/master/sys_catalog.cc@1155 PS10, Line 1155: const SysTablesEntryPB& metadata) { nit: alignment http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/tools/kudu-admin-test.cc@3132 PS10, Line 3132: /*is_secure*/false, /*log_to_stderr*/true, part_tables), nit: alignment http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/tools/kudu-admin-test.cc@3137 PS10, Line 3137: ASSERT_STR_CONTAINS(stdout, "Rebuilt from 2 replicas, of which 0 had errors"); After master been rebuilt, it's better to restart the cluster and check everything running as expect. http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/tools/kudu-admin-test.cc@3151 PS10, Line 3151: ASSERT_STR_CONTAINS(stdout, "Rebuilt from 3 replicas, of which 0 had errors"); same http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/tools/master_rebuilder.cc@81 PS10, Line 81: using std::string; : using std::set; nit: keep them in lexicographical order. http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/tools/master_rebuilder.cc@130 PS10, Line 130: if (!filter_tables.empty() && !ContainsKey(filter_tables, table_name)) continue; If the table you specified in FLAGS_tables is not found in replicas, report an error? http://gerrit.cloudera.org:8080/#/c/18572/10/src/kudu/tools/master_rebuilder.cc@167 PS10, Line 167: FLAGS_tables nit: better to judge on filter_tables, since there maybe some invalid characters in FLAGS_tables before strings::Split -- To view, visit http://gerrit.cloudera.org:8080/18572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d812c8a16228ac937603872161969eb05136eb Gerrit-Change-Number: 18572 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 26 Jun 2022 08:38:44 +0000 Gerrit-HasComments: Yes
