Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18672 )
Change subject: KUDU-2671 introduce PartitionPruner::PrepareRangeSet() ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18672/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18672/2//COMMIT_MSG@27 PS2, Line 27: prunning nit: pruning http://gerrit.cloudera.org:8080/#/c/18672/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18672/2/src/kudu/common/partition.cc@311 PS2, Line 311: sort(ranges_with_custom_hash_schemas.begin(), Perhaps we could add an comment about this field being sorted in the header file. http://gerrit.cloudera.org:8080/#/c/18672/2/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/18672/2/src/kudu/common/partition_pruner.cc@370 PS2, Line 370: while (cur_idx < ranges.size() && Talked about this offline, but some more comments in the while loop for each block would help. -- To view, visit http://gerrit.cloudera.org:8080/18672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1903a444d47d30bbd7e119977cbb87bf1aa458 Gerrit-Change-Number: 18672 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 27 Jun 2022 20:13:03 +0000 Gerrit-HasComments: Yes
