Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18672 )
Change subject: KUDU-2671 introduce PartitionPruner::PrepareRangeSet() ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18672/3/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/18672/3/src/kudu/common/partition_pruner.cc@416 PS3, Line 416: (!scan_upper_bound.empty() && scan_upper_bound <= cur_range.upper) || : cur_range.upper.empty()) { : result.emplace_back(PartitionSchema::RangeWithHashSchema{ : cur_po To be consistent with the other comments, would prefer if this visual was included in the comments. http://gerrit.cloudera.org:8080/#/c/18672/5/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/18672/5/src/kudu/common/partition_pruner.cc@414 PS5, Line 414: iterator points to the upper bound of the current range : // or to the upper bound of the scan. nit: modify comment to make it more clear that the iterator will point to upper bound of current range or upper bound of the scan *after* this else block is executed, if not seems like the iterator points there at this part of the code. -- To view, visit http://gerrit.cloudera.org:8080/18672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1903a444d47d30bbd7e119977cbb87bf1aa458 Gerrit-Change-Number: 18672 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 28 Jun 2022 03:57:21 +0000 Gerrit-HasComments: Yes
