Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18642 )
Change subject: KUDU-2671 update partition schema in catalog when dropping range ...................................................................... Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/common/partition-test.cc@1492 PS8, Line 1492: RangeSchemaPB, nit: RangeWithHashSchemaPB http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/common/partition-test.cc@1494 PS8, Line 1494: tablet nit: table http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/common/partition-test.cc@1497 PS8, Line 1497: RangeSchemaPB nit: RangeWithHashSchemaPB http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/common/partition-test.cc@2163 PS8, Line 2163: truly nit: remove 'truly' http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/common/partition.h@310 PS8, Line 310: with nit: remove extra with http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/common/partition_pruner-test.cc File src/kudu/common/partition_pruner-test.cc: http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/common/partition_pruner-test.cc@1124 PS8, Line 1124: PartitionSchema::RangesWithHashSchemas ranges; : ASSERT_OK(PartitionSchema::FromPB(pb, schema, &partition_schema, &ranges)); : : vector<Partition> partitions; : ASSERT_OK(partition_schema.CreatePartitions(ranges, schema, &partitions)); So to understand the usage of 'ranges'. Now since we're only storing the ranges with custom hash schema in PartitionSchema, we need to return all the ranges with their hash schema within the 'ranges' parameter in PartitionSchema::FromPB(). Then, that's being propagated to CreatePartitions so all the proper partitions can be created. http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18642/8/src/kudu/master/catalog_manager.cc@1939 PS8, Line 1939: based on specified ranges with custom hash schemas. Doesn't this method create partitions for each range, regardless of custom or table wide hash schema. -- To view, visit http://gerrit.cloudera.org:8080/18642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib78afdd1a358751dca43f564c5d8e69191f165d4 Gerrit-Change-Number: 18642 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 28 Jun 2022 19:45:55 +0000 Gerrit-HasComments: Yes
