Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18642 )

Change subject: KUDU-2671 update partition schema in catalog when dropping range
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18642/6/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:

http://gerrit.cloudera.org:8080/#/c/18642/6/src/kudu/common/partition.cc@1770
PS6, Line 1770: if (updated_array.back().hash_schema != hash_schema_) {
              :       updated_array.emplace_back(updated_array.back());
              :     }
> As discussed, we seem to be string the same element twice in the vector her
Good catch!  I'm not sure how it ended up like this.



--
To view, visit http://gerrit.cloudera.org:8080/18642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib78afdd1a358751dca43f564c5d8e69191f165d4
Gerrit-Change-Number: 18642
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jun 2022 00:55:11 +0000
Gerrit-HasComments: Yes

Reply via email to