Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18672 )
Change subject: KUDU-2671 introduce PartitionPruner::PrepareRangeSet() ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18672/7/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/18672/7/src/kudu/common/partition_pruner.cc@363 PS7, Line 363: CHECK(range_it != ranges.cend()); > nit: CHECK_NE? That would work if we defined an operator to output RangeWithHashSchema into ostream, but since we didn't, CHECK_NE() results in compilation error: thirdparty/installed/uninstrumented/include/glog/logging.h:638:9: error: invalid operands to binary expression ('std::ostream' (aka 'basic_ostream<char>') and 'const std::__1::__wrap_iter<const kudu::PartitionSchema::RangeWithHashSchema *>') (*os) << v; ~~~~~ ^ ~ ... /src/kudu/common/partition_pruner.cc:363:3: note: in instantiation of function template specialization 'google::Check_NEImpl<std::__1::__wrap_iter<const kudu::PartitionSchema::RangeWithHashSchema *>, std::__1::__wrap_iter<const kudu::PartitionSchema::RangeWithHashSchema *> >' requested here CHECK_NE(ranges.cend(), range_it); I think we can use CHECK() here and avoid introducing some extra code which would work only in the-thing-that-should-not-be case :) -- To view, visit http://gerrit.cloudera.org:8080/18672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1903a444d47d30bbd7e119977cbb87bf1aa458 Gerrit-Change-Number: 18672 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 29 Jun 2022 17:45:58 +0000 Gerrit-HasComments: Yes
