Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18672 )
Change subject: KUDU-2671 introduce PartitionPruner::PrepareRangeSet() ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18672/6/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/18672/6/src/kudu/common/partition_pruner.cc@398 PS6, Line 398: // ranges[cur_idx].lower == cur_point nit: unnecessary. http://gerrit.cloudera.org:8080/#/c/18672/6/src/kudu/common/partition_pruner.cc@414 PS6, Line 414: ranges[cur_idx].lower nit: to be consistent, can use 'cur_range' here instead. Also, seems to be an unnecessary indent. -- To view, visit http://gerrit.cloudera.org:8080/18672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1903a444d47d30bbd7e119977cbb87bf1aa458 Gerrit-Change-Number: 18672 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 28 Jun 2022 06:34:20 +0000 Gerrit-HasComments: Yes
