Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17879 )
Change subject: KUDU-2671: WIP Follow up pruning patch. ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/17879/10/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/17879/10/src/kudu/common/partition_pruner.cc@565 PS10, Line 565: auto partition_key_ranges = ConstructPartitionKeyRanges( : schema, scan_spec, hash_schema, range_bounds); : for (auto& partition_key_range : partition_key_ranges) { : partition_key_ranges_.emplace_back(std::move(partition_key_range)); : } > Instead, is it possible to do something like I don't see how that would work, we need to append the new set of ranges being constructed to the field each time. I believe this approach would just replace the existing ranges. -- To view, visit http://gerrit.cloudera.org:8080/17879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a1bf5344c0ef856072d3ed102714dce5ba21060 Gerrit-Change-Number: 17879 Gerrit-PatchSet: 10 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 01 Jul 2022 18:48:55 +0000 Gerrit-HasComments: Yes
