Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17879 )
Change subject: KUDU-2671: WIP Follow up pruning patch. ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/17879/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17879/10//COMMIT_MSG@7 PS10, Line 7: WIP > What needs to be addressed in this patch to remove the WIP tag? Are those yep sorry if that wasn't clear, but the test related failures. I would say the ScanToken one is more of a show-stopper since none of those tests pass. As discussed previously, only a few certain test cases fail with the KuduScanner and using predicates, and none of them were reproducible in a real life cluster. http://gerrit.cloudera.org:8080/#/c/17879/10/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/17879/10/src/kudu/common/partition_pruner.cc@565 PS10, Line 565: auto partition_key_ranges = ConstructPartitionKeyRanges( : schema, scan_spec, hash_schema, range_bounds); : partition_key_ranges_.resize(partition_key_ranges_.size() + partition_key_ranges.size()); : move(partition_key_ranges.begin(), partition_key_ranges.end(), : > Indeed -- it seems I missed the presence of that 'for' outside cycle. Done -- To view, visit http://gerrit.cloudera.org:8080/17879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a1bf5344c0ef856072d3ed102714dce5ba21060 Gerrit-Change-Number: 17879 Gerrit-PatchSet: 11 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 01 Jul 2022 19:23:53 +0000 Gerrit-HasComments: Yes
