Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18454 )

Change subject: [master] KUDU-3061 support auto rebalance tablet leaders across 
TServers
......................................................................


Patch Set 19:

(1 comment)

I didn't really look into the codes because I'd like to understand the design 
consideration and the use of algorithm first.
Here are some questions I don't know much about:
- Is this leader rebalance task only transfer the leadership between replicas 
of the same tablet? Or it also copy replicas from one server to another?
- Do we have to rebalance replicas in a cluster before we run this leader 
rebalance task?
- Can we finally get a fully balanced cluster in all cases?

If you already have a design document about this issue, can you share it so wen 
can discuss about the details.

http://gerrit.cloudera.org:8080/#/c/18454/19//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18454/19//COMMIT_MSG@14
PS19, Line 14: Two reasons of load skew:
Besides clarify why we need to balance leader replicas across TServers, it 
would be better if you can show the skew of leaders in a cluster before and 
after run the balance task.



--
To view, visit http://gerrit.cloudera.org:8080/18454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb60d8759a93b6a19238637c27df4f6b1cac918
Gerrit-Change-Number: 18454
Gerrit-PatchSet: 19
Gerrit-Owner: Yuqi Du <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Sun, 03 Jul 2022 16:17:30 +0000
Gerrit-HasComments: Yes

Reply via email to