Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18454 )

Change subject: [master] KUDU-3061 support auto rebalance tablet leaders across 
TServers
......................................................................


Patch Set 20:

> For a specific table,  its replicas assigned to tservers(by create table or 
> rebalance task), at a specific tserver should satisfy
> number of leaders : number of followers is 1 : (replica_refactor -1).
>
> every table should do leader rebalance.

(number of leaders) / (number of followers) == 1 / (replica_refactor - 1), is 
too rough IMO, there are some cases you should cover and mention:
1. the replica factor is 1.
2. the number of tserver is far greater than the number of total replicas.

And I suggest to make sure replica is balanced before rebalance replica leader.


--
To view, visit http://gerrit.cloudera.org:8080/18454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb60d8759a93b6a19238637c27df4f6b1cac918
Gerrit-Change-Number: 18454
Gerrit-PatchSet: 20
Gerrit-Owner: Yuqi Du <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Fri, 08 Jul 2022 08:26:29 +0000
Gerrit-HasComments: No

Reply via email to