Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18721 )
Change subject: KUDU-2671: Extra test coverage for KuduScanTokens. ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@748 PS1, Line 748: unique_ptr<KuduPartialRow> lower_bound(schema.NewRow()); : unique_ptr<KuduPartialRow> upper_bound(schema.NewRow()); nit: instead of defining these and ten calling 'reset' every time upon reuse in a few scopes below, maybe move these into the corresponding scopes? http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@761 PS1, Line 761: nit: wrong indent http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@772 PS1, Line 772: nit: wrong indent http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@773 PS1, Line 773: range_partition->add_hash_partitions({ "col"}, 2); nit: missing space? http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@886 PS1, Line 886: } Do you mind adding sub-scenarios for the following: * predicate defining the exactly non-covered range, i.e. 100 <= x < 200 * predicate defining a range that intersects with both covered ranges and the non-covered range, i.e. 50 <= x < 250 * predicate defining a range that covers all the ranges and also the ranges at the left and the right, i.e. -50 <= x < 350 ? -- To view, visit http://gerrit.cloudera.org:8080/18721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dec5c713940c1f8d66416c6a287b93e250d90e6 Gerrit-Change-Number: 18721 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 13 Jul 2022 00:17:30 +0000 Gerrit-HasComments: Yes
