Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18721 )
Change subject: KUDU-2671: Extra test coverage for KuduScanTokens. ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@748 PS1, Line 748: table_creator->table_name("table"); : table_creator->num_replicas(1); > nit: instead of defining these and ten calling 'reset' every time upon reus Done http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@761 PS1, Line 761: > nit: wrong indent Done http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@772 PS1, Line 772: > nit: wrong indent Done http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@773 PS1, Line 773: } > nit: missing space? Done http://gerrit.cloudera.org:8080/#/c/18721/1/src/kudu/client/scan_token-test.cc@886 PS1, Line 886: "col", KuduPredicate::EQUAL, KuduValue::FromInt(242))); > Do you mind adding sub-scenarios for the following: Done -- To view, visit http://gerrit.cloudera.org:8080/18721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dec5c713940c1f8d66416c6a287b93e250d90e6 Gerrit-Change-Number: 18721 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 13 Jul 2022 01:40:32 +0000 Gerrit-HasComments: Yes
