Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18241 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema ...................................................................... Patch Set 19: (1 comment) > Patch Set 19: > > (44 comments) > > Thank you for the patch! > > I started reviewing this patch, accumulated some review feedback and then > found that too many updates are incorporated into a single patch. > > I think that for tracking the changes in posterity and for the review process > it would be great to post the following patches separately, in this > dependency/base order: > * non-essential updates on the original code The first step is implemented in https://gerrit.cloudera.org/c/18724/, please take a look, thanks! http://gerrit.cloudera.org:8080/#/c/18241/19/src/kudu/client/write_op.h File src/kudu/client/write_op.h: http://gerrit.cloudera.org:8080/#/c/18241/19/src/kudu/client/write_op.h@144 PS19, Line 144: ~KuduInsert() override; > Here and below: please move this and other non-essential update into a sepa Done -- To view, visit http://gerrit.cloudera.org:8080/18241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If80ebca7d3ab14db1591c14201f6d561155526cd Gerrit-Change-Number: 18241 Gerrit-PatchSet: 19 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 13 Jul 2022 16:17:09 +0000 Gerrit-HasComments: Yes
