Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18241 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema ...................................................................... Patch Set 20: (4 comments) Changes on server side and proto files, and some other neccessary changed finished on a new patch: https://gerrit.cloudera.org/c/18742/ http://gerrit.cloudera.org:8080/#/c/18241/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18241/18//COMMIT_MSG@10 PS18, Line 10: been written > nit: it's been written during inserting the row Done http://gerrit.cloudera.org:8080/#/c/18241/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18241/19//COMMIT_MSG@15 PS19, Line 15: able > possible Done http://gerrit.cloudera.org:8080/#/c/18241/19//COMMIT_MSG@15 PS19, Line 15: All the old column : data in the table has the default immutable value, new insertion can : specify a cell value on the column or not, if not, default value will be : used. > Is this any different from the behavior of any other column that has defaul Indeed, they are the same. I've removed it. http://gerrit.cloudera.org:8080/#/c/18241/19/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/18241/19/src/kudu/tablet/tablet_metrics.cc@46 PS19, Line 46: due to an error > If there is any other error except for the immutability of a column in this Done -- To view, visit http://gerrit.cloudera.org:8080/18241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If80ebca7d3ab14db1591c14201f6d561155526cd Gerrit-Change-Number: 18241 Gerrit-PatchSet: 20 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 17 Jul 2022 16:38:09 +0000 Gerrit-HasComments: Yes
