Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18674 )
Change subject: [threadpool] Fix scheduler thread a coredump bug ...................................................................... Patch Set 26: (4 comments) http://gerrit.cloudera.org:8080/#/c/18674/24/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/18674/24/src/kudu/util/threadpool-test.cc@193 PS24, Line 193: ASSERT_OK(token->Schedule(&IssueTraceStatement, 200)); > error: no viable conversion from 'std::shared_ptr<ThreadPoolToken>' to 'uni Done http://gerrit.cloudera.org:8080/#/c/18674/24/src/kudu/util/threadpool-test.cc@1063 PS24, Line 1063: > error: no viable overloaded '=' [clang-diagnostic-error] Done http://gerrit.cloudera.org:8080/#/c/18674/24/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/18674/24/src/kudu/util/threadpool.cc@261 PS24, Line 261: if (PREDICT_FALSE(!MaySubmitNewTasks())) { > warning: the parameter 'f' is copied for each invocation but only used as a Done http://gerrit.cloudera.org:8080/#/c/18674/24/src/kudu/util/threadpool.cc@269 PS24, Line 269: } > error: no viable conversion from 'shared_ptr<kudu::ThreadPoolToken>' to 'ku Done -- To view, visit http://gerrit.cloudera.org:8080/18674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5bc5511a745f3dc12dfe1a6a1813ece41ccc2a8 Gerrit-Change-Number: 18674 Gerrit-PatchSet: 26 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 14 Jul 2022 02:36:55 +0000 Gerrit-HasComments: Yes
