Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18674 )
Change subject: [threadpool] Fix scheduler thread a coredump bug ...................................................................... Patch Set 29: (5 comments) http://gerrit.cloudera.org:8080/#/c/18674/29//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18674/29//COMMIT_MSG@11 PS29, Line 11: You described the background, it's better to ddescribe how do you fix the bug. http://gerrit.cloudera.org:8080/#/c/18674/29/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/18674/29/src/kudu/util/threadpool-test.cc@195 PS29, Line 195: SleepFor(MonoDelta::FromMilliseconds(1000)); If all tasks in token finished, it's not needed to sleep, right? http://gerrit.cloudera.org:8080/#/c/18674/29/src/kudu/util/threadpool-test.cc@267 PS29, Line 267: nit: remove the blank line. http://gerrit.cloudera.org:8080/#/c/18674/29/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/18674/29/src/kudu/util/threadpool.cc@159 PS29, Line 159: if (s.IsServiceUnavailable()) { nit: you can DCHECK(s.IsServiceUnavailable()) to reduce if..else.. and indents. http://gerrit.cloudera.org:8080/#/c/18674/29/src/kudu/util/threadpool.cc@164 PS29, Line 164: generally not reach the branch Better toi describe how it happened. -- To view, visit http://gerrit.cloudera.org:8080/18674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5bc5511a745f3dc12dfe1a6a1813ece41ccc2a8 Gerrit-Change-Number: 18674 Gerrit-PatchSet: 29 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 15 Jul 2022 09:09:18 +0000 Gerrit-HasComments: Yes
