Hello Mahesh Reddy, Tidy Bot, Kurt Deschler, Attila Bukor, Kudu Jenkins,
Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18728
to look at the new patch set (#2).
Change subject: KUDU-2671 check for duplicate columns in hash schema when
adding range
......................................................................
KUDU-2671 check for duplicate columns in hash schema when adding range
This patch adds validation for the range-specific hash schema when
adding a new range partition. Without this patch, invalid requests
to add a range partitions with duplicate columns across hash dimensions
of the custom hash schema would be accepted, but tablets could not be
created, resulting in timed-out IsAlterTableDone() RPC. The patch also
contains new test scenarios for both the C++ and the Java clients,
making sure the corresponding error is reported back to the client.
I verified that the new scenarios failed as expected if commenting out
the newly added schema validation code.
This patch also fixes a few typos in test scenarios from master-test.cc
since the new verification coded exposed those mistakes.
Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
5 files changed, 288 insertions(+), 117 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18728/2
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
