Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18728 )
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range ...................................................................... KUDU-2671 check for duplicate columns in hash schema when adding range This patch adds validation for range-specific hash schemas when adding new range partitions. Without this patch, invalid requests to add range partitions with duplicate columns across dimensions of the custom hash schema would be accepted, but tablets could not be created, resulting in timed-out IsAlterTableDone() RPC. The patch also contains new test scenarios for both C++ and Java Kudu clients, making sure the corresponding error is reported back to the client. I verified that the new test scenarios failed as expected if commenting out the newly added hash schema validation code. This patch also fixes a few typos in test scenarios from master-test.cc since the new verification code exposed those mistakes. Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e Reviewed-on: http://gerrit.cloudera.org:8080/18728 Reviewed-by: Mahesh Reddy <[email protected]> Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java M src/kudu/client/flex_partitioning_client-test.cc M src/kudu/common/partition.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master-test.cc 5 files changed, 283 insertions(+), 117 deletions(-) Approvals: Mahesh Reddy: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved; Verified Abhishek Chennaka: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/18728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e Gerrit-Change-Number: 18728 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]>
