Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18572 )
Change subject: [Tools] Rebuild master according to part of tables not all tables ...................................................................... Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/18572/26/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18572/26/src/kudu/tools/master_rebuilder.cc@473 PS26, Line 473: SysCatalogTable::SysCatalogOperation::UPDATE It seems this UPDATE operation wouldn't take effect on master's SysCatalogTable, it would be treated as an empty update in SysCatalogTable::ReqUpdateTable(). On second thought, it doesn't seem to make sense to update the metadata directly. In this case, perhaps we should return an AlreadyPresent ERROR and tell the user that a table already exists and that if they really want to rebuild the table, they can manually delete it and run the tool again. -- To view, visit http://gerrit.cloudera.org:8080/18572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d812c8a16228ac937603872161969eb05136eb Gerrit-Change-Number: 18572 Gerrit-PatchSet: 26 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 18 Jul 2022 13:17:48 +0000 Gerrit-HasComments: Yes
