Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18572 )
Change subject: [Tools] Rebuild master according to part of tables not all tables ...................................................................... Patch Set 32: (2 comments) > Patch Set 31: Code-Review+1 > > (2 comments) > > Overall looks good now, just a few more nits. http://gerrit.cloudera.org:8080/#/c/18572/31/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18572/31/src/kudu/tools/master_rebuilder.cc@100 PS31, Line 100: tablet_by_name > nit: maybe make it a default parameter with the default value 'nullptr', an Done http://gerrit.cloudera.org:8080/#/c/18572/31/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/18572/31/src/kudu/tools/tool_action_master.cc@931 PS31, Line 931: " - Without '--tables', the tool will build a brand new syscatalog table based on " > nit: I think we should highlight the difference between with and without '- Done -- To view, visit http://gerrit.cloudera.org:8080/18572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d812c8a16228ac937603872161969eb05136eb Gerrit-Change-Number: 18572 Gerrit-PatchSet: 32 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 21 Jul 2022 10:02:13 +0000 Gerrit-HasComments: Yes
