Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18674 )
Change subject: [threadpool] Fix scheduler thread a coredump bug ...................................................................... Patch Set 36: (6 comments) Thanks for your crs. http://gerrit.cloudera.org:8080/#/c/18674/34/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/18674/34/src/kudu/util/threadpool-test.cc@193 PS34, Line 193: ASSERT_OK(token->Schedule(&IssueTraceStatement, 200)); : token->Shutdown(); : SleepFor(MonoDelta::FromMilliseconds(500)); > What does it want to provide? Seems not related to the test name, i.e. Thre ok http://gerrit.cloudera.org:8080/#/c/18674/34/src/kudu/util/threadpool-test.cc@198 PS34, Line 198: } > nit: remove it Done http://gerrit.cloudera.org:8080/#/c/18674/34/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/18674/34/src/kudu/util/threadpool.h@200 PS34, Line 200: `futur > nit: future_tasks_ ? Done http://gerrit.cloudera.org:8080/#/c/18674/34/src/kudu/util/threadpool.h@203 PS34, Line 203: Tasks order by their execute timepoint. The `thread_` would e > how about some like: Tasks by their earliest execute time. Tasks will execu I can change the comment. Although what you said is nearly fact, but I think origin intention is better. http://gerrit.cloudera.org:8080/#/c/18674/34/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/18674/34/src/kudu/util/threadpool.cc@154 PS34, Line 154: while (token != nullptr) { > IMO, token is possible to be a wild pointer, isn't it? Yes. So need notice usage. 1. thread_pool shutdown then the thread join. 2. token shutdown and release. 3. release thread_pool http://gerrit.cloudera.org:8080/#/c/18674/34/src/kudu/util/threadpool.cc@168 PS34, Line 168: G(1) << Substitute("threadpool token Submit status: $0, retry t > I'm not sure what does it mean, could you please explain more about it? remove it. -- To view, visit http://gerrit.cloudera.org:8080/18674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5bc5511a745f3dc12dfe1a6a1813ece41ccc2a8 Gerrit-Change-Number: 18674 Gerrit-PatchSet: 36 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 20 Jul 2022 04:20:35 +0000 Gerrit-HasComments: Yes
