Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18761 )
Change subject: KUDU-3384: Handling IncrementEncodedKey failure ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Thank you for fixing this! Overall looks good, just a few nits. http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set-test.cc File src/kudu/tablet/cfile_set-test.cc: http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set-test.cc@655 PS1, Line 655: Regression nit: Regression test http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set-test.cc@657 PS1, Line 657: const nit: could be constexpr? http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set.cc@446 PS1, Line 446: EncodedKey::IncrementEncodedKey This might return Status::RuntimeError() due to out-of-memory condition. Could you add an explanation why it's possible to continue in such case even if the upper bound is something less that maximum possible value for the primary key and still get correct results for the scan? -- To view, visit http://gerrit.cloudera.org:8080/18761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c48f9893364c3fad5597431e4acfbcb2a4b43d Gerrit-Change-Number: 18761 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 Jul 2022 19:06:29 +0000 Gerrit-HasComments: Yes
