Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18761 )
Change subject: KUDU-3384: Handling IncrementEncodedKey failure ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set-test.cc File src/kudu/tablet/cfile_set-test.cc: http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set-test.cc@655 PS1, Line 655: Regression > nit: Regression test Done http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set-test.cc@657 PS1, Line 657: const > nit: could be constexpr? Done http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/18761/1/src/kudu/tablet/cfile_set.cc@446 PS1, Line 446: e exclusive_upper_bound_key onl > This might return Status::RuntimeError() due to out-of-memory condition. C Done -- To view, visit http://gerrit.cloudera.org:8080/18761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c48f9893364c3fad5597431e4acfbcb2a4b43d Gerrit-Change-Number: 18761 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 21 Jul 2022 04:14:43 +0000 Gerrit-HasComments: Yes
