Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18645 )
Change subject: [ranger-kms] KUDU-3385 - part2: mini_ranger init ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/18645/12/src/kudu/ranger-kms/mini_ranger_kms.cc File src/kudu/ranger-kms/mini_ranger_kms.cc: http://gerrit.cloudera.org:8080/#/c/18645/12/src/kudu/ranger-kms/mini_ranger_kms.cc@328 PS12, Line 328: MiniRangerKMS::GetKeys() Should the response be saved as a result of receiving keys from KMS? http://gerrit.cloudera.org:8080/#/c/18645/12/src/kudu/ranger-kms/mini_ranger_kms.cc@333 PS12, Line 333: curl.FetchURL What if FetchURL returns non-OK? Should this be wrapped into RETURN_NOT_OK()? -- To view, visit http://gerrit.cloudera.org:8080/18645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11617468245068dd732fb3f2578bb086b2f6024f Gerrit-Change-Number: 18645 Gerrit-PatchSet: 12 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 21 Jul 2022 21:59:25 +0000 Gerrit-HasComments: Yes
