Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18645 )
Change subject: [ranger-kms] KUDU-3385 - part2: mini_ranger init ...................................................................... Patch Set 16: (3 comments) It seems PS16 somehow overwritten changes made by Zoltan in PS15. http://gerrit.cloudera.org:8080/#/c/18645/16/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/18645/16/src/kudu/mini-cluster/external_mini_cluster.h@225 PS16, Line 225: port nit: part http://gerrit.cloudera.org:8080/#/c/18645/16/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/18645/16/src/kudu/mini-cluster/external_mini_cluster.cc@20 PS16, Line 20: #include <csignal> : #include <cstdlib> : : #include <algorithm> : #include <cstdint> nit: it seems the version in PS15 was more consistent with our current coding style http://gerrit.cloudera.org:8080/#/c/18645/16/src/kudu/postgres/mini_postgres.h File src/kudu/postgres/mini_postgres.h: http://gerrit.cloudera.org:8080/#/c/18645/16/src/kudu/postgres/mini_postgres.h@72 PS16, Line 72: std::string host() const { Why to remove the 'const std::string& part'? -- To view, visit http://gerrit.cloudera.org:8080/18645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11617468245068dd732fb3f2578bb086b2f6024f Gerrit-Change-Number: 18645 Gerrit-PatchSet: 16 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 22 Jul 2022 18:51:02 +0000 Gerrit-HasComments: Yes
