Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18791 )
Change subject: WIP KUDU-2671: Restore custom hash schemas properly ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18791/1/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala File java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala: http://gerrit.cloudera.org:8080/#/c/18791/1/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@385 PS1, Line 385: val schema = getKuduSchema(metadata) : metadata.getPartitions.getRangeAndHashPartitionsList.asScala.map { rhp => : val lower = getPartialRow(rhp.getBounds.getLowerBoundsList.asScala, schema) : val upper = getPartialRow(rhp.getBounds.getUpperBoundsList.asScala, schema) : val currentRange = new RangePartitionWithCustomHashSchema( : lower, : upper, : RangePartitionBound.INCLUSIVE_BOUND, : RangePartitionBound.EXCLUSIVE_BOUND) : rhp.getHashPartitionsList.asScala.map { hp => : currentRange.addHashPartitions(hp.getColumnNamesList, hp.getNumBuckets, hp.getSeed) : } : options.addRangePartition(currentRange) : } > I'm not sure I understand how this affects the code in createTableRangePart Yep that's a good point, I'll actually have to modify how the range partitions are built in createTableRangePartitionByRangePartition() so custom hash schemas are properly reflected in the ranges that require them. -- To view, visit http://gerrit.cloudera.org:8080/18791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c28b306f2b630a609231a8fb2a5f5652b028d8e Gerrit-Change-Number: 18791 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 27 Jul 2022 20:59:11 +0000 Gerrit-HasComments: Yes
