Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18791 )
Change subject: KUDU-2671: Restore custom hash schemas properly ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18791/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/18791/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@366 PS5, Line 366: */ > Instead of duplicating almost all the code, maybe create a method that take Done http://gerrit.cloudera.org:8080/#/c/18791/5/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java File java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java: http://gerrit.cloudera.org:8080/#/c/18791/5/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java@29 PS5, Line 29: Limite > I'm not sure we want to expose a lot of this stuff outside at this point. Changed to LimitedPrivate("Test), but I suppose I don't really understand the purpose of @InterfaceAudience. My understanding is that it just lets the end user know the scope of the class, is that accurate? -- To view, visit http://gerrit.cloudera.org:8080/18791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c28b306f2b630a609231a8fb2a5f5652b028d8e Gerrit-Change-Number: 18791 Gerrit-PatchSet: 6 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Sat, 30 Jul 2022 02:29:31 +0000 Gerrit-HasComments: Yes
