Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support turning on/off auto rebalancer at runtime ...................................................................... Patch Set 28: (4 comments) Can we have a Jira for this work in the commit message. It would be easier to track the work in future. Thanks! http://gerrit.cloudera.org:8080/#/c/18679/28/src/kudu/master/auto_rebalancer.h File src/kudu/master/auto_rebalancer.h: http://gerrit.cloudera.org:8080/#/c/18679/28/src/kudu/master/auto_rebalancer.h@87 PS28, Line 87: replicas is not imbalanced Replace with: distribution of replicas is not balanced. http://gerrit.cloudera.org:8080/#/c/18679/28/src/kudu/master/auto_rebalancer.h@90 PS28, Line 90: Replica moves Move Replicas http://gerrit.cloudera.org:8080/#/c/18679/28/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/18679/28/src/kudu/master/catalog_manager.h@1260 PS28, Line 1260: use nit: uses http://gerrit.cloudera.org:8080/#/c/18679/28/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18679/28/src/kudu/master/catalog_manager.cc@158 PS28, Line 158: every schedule_period_ms scheduler pool would check time and may run some tasks nit: Maybe replace with something like: Time intervals at which scheduler pool checks for tasks to be run. -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 28 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 08 Aug 2022 16:19:55 +0000 Gerrit-HasComments: Yes
