Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] KUDU-3389 support turning on/off auto rebalancer at runtime ...................................................................... Patch Set 30: (2 comments) Generally LGTM. http://gerrit.cloudera.org:8080/#/c/18679/30//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18679/30//COMMIT_MSG@15 PS30, Line 15: We can nit: This patch also optimizes it to http://gerrit.cloudera.org:8080/#/c/18679/30/src/kudu/master/auto_rebalancer.h File src/kudu/master/auto_rebalancer.h: http://gerrit.cloudera.org:8080/#/c/18679/30/src/kudu/master/auto_rebalancer.h@90 PS30, Line 90: not remove it -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 30 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 10 Aug 2022 07:17:57 +0000 Gerrit-HasComments: Yes
