Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18454 )
Change subject: [master] KUDU-3390 support auto rebalance tablet leaders across TServers ...................................................................... Patch Set 24: (4 comments) Sorry for missing some crs. http://gerrit.cloudera.org:8080/#/c/18454/12/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18454/12/src/kudu/master/auto_leader_rebalancer.cc@165 PS12, Line 165: : : auto& uuid_replicas = LookupOrInsert(&uuid_replicas_map, ts_info.permanent_uuid(), {}); : uuid_replicas.emplace_back(tablet->id()); : } : } > Changed it, and I'll study it later. Done http://gerrit.cloudera.org:8080/#/c/18454/12/src/kudu/master/auto_leader_rebalancer.cc@175 PS12, Line 175: ring, std::pair<int32_t, int32_t>> tserver_statistics; : // uuid->leader should transfer count : map<string, int32_t> leader_transfer_source; : for (const auto& uuid : tserver_uuids) { : const vector<string>& replicas = FindWithDefault(uuid_replicas_map, uuid, {}); : uint3 > Same Done http://gerrit.cloudera.org:8080/#/c/18454/12/src/kudu/master/auto_leader_rebalancer.cc@186 PS12, Line 186: nt32_t leader_count = leaders.size(); : tserver_statistics.insert({uuid, std::pair<int32_t, int32_t>(replica_count, leader_count)}); : VLOG(1) << Substitute( : "uuid: $0, replica_count: $1, leader_count: $2", uuid, replica_count, leader_count); : : // Our target is every tserver' replicas, number of leader : number of follower is : // > Same Done http://gerrit.cloudera.org:8080/#/c/18454/12/src/kudu/master/auto_leader_rebalancer.cc@323 PS12, Line 323: return Status::OK(); > There are several code can be optimized by util functions in src/kudu/gutil Done -- To view, visit http://gerrit.cloudera.org:8080/18454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb60d8759a93b6a19238637c27df4f6b1cac918 Gerrit-Change-Number: 18454 Gerrit-PatchSet: 24 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 19 Aug 2022 10:10:33 +0000 Gerrit-HasComments: Yes
