Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18903
Change subject: KUDU-3379 Add column comments to table describe ...................................................................... KUDU-3379 Add column comments to table describe This patch adds --show_column_comment flag to kudu table describe. If there are column comments specified, this can be used to show them. Schema and ColumnSchema use the ToStringMode enum to control, how they are stringified. Previously these were used to signal a single mode of the stringification. Now both are populated through bit shifting. This way the enum can be used as a holder of multiple binary flags. We can check for the presence of a flag through 'and' operator, and set a given flag through the 'or' operator. A new test case is added to check whether the column describing flags work, alone and together as well. Change-Id: Id8b751bd821a5f50490caa6f1aaf1fc767de0222 --- M src/kudu/client/schema.cc M src/kudu/common/schema.cc M src/kudu/common/schema.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_table.cc M src/kudu/tserver/tablet_service.cc 6 files changed, 148 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/18903/1 -- To view, visit http://gerrit.cloudera.org:8080/18903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id8b751bd821a5f50490caa6f1aaf1fc767de0222 Gerrit-Change-Number: 18903 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]>
