Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18903 )
Change subject: KUDU-3379 Add column comments to table describe ...................................................................... Patch Set 2: Code-Review+1 (3 comments) few nits, otherwise looks good to me http://gerrit.cloudera.org:8080/#/c/18903/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18903/2//COMMIT_MSG@12 PS2, Line 12: , nit: unnecessary comma http://gerrit.cloudera.org:8080/#/c/18903/2//COMMIT_MSG@16 PS2, Line 16: operator nit: these are 'bitwise and' and 'bitwise or' operators http://gerrit.cloudera.org:8080/#/c/18903/2/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/18903/2/src/kudu/common/schema.cc@473 PS2, Line 473: = col_mode | > nit: would '=|' operator work here automatically or it's necessary to defin Wouldn't that be '|=' instead? Also I'm curious as well about it. -- To view, visit http://gerrit.cloudera.org:8080/18903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8b751bd821a5f50490caa6f1aaf1fc767de0222 Gerrit-Change-Number: 18903 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 25 Aug 2022 14:21:07 +0000 Gerrit-HasComments: Yes
