KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18864 )
Change subject: KUDU-3326 [master] add flag FLAGS_enable_soft_delete_on_master to enable soft-delete on master ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/18864/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18864/1//COMMIT_MSG@9 PS1, Line 9: help to changes > nit: "helps change the" Done http://gerrit.cloudera.org:8080/#/c/18864/1//COMMIT_MSG@10 PS1, Line 10: enable > nit: "is enabled" Done http://gerrit.cloudera.org:8080/#/c/18864/1//COMMIT_MSG@10 PS1, Line 10: set 0 > "set to 0" Done http://gerrit.cloudera.org:8080/#/c/18864/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18864/1/src/kudu/client/client-test.cc@5210 PS1, Line 5210: No one table > nit: Change to "No tables" Done http://gerrit.cloudera.org:8080/#/c/18864/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18864/1/src/kudu/master/catalog_manager.cc@416 PS1, Line 416: DEFINE_uint32(table_reserve_seconds, 60 * 60 * 24 * 7, > Can you include this in the testing of the new flag? Done -- To view, visit http://gerrit.cloudera.org:8080/18864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cf3021fa0e9a425d5f8091ea3336c55a3c14bbc Gerrit-Change-Number: 18864 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 25 Aug 2022 02:46:30 +0000 Gerrit-HasComments: Yes
