Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18864 )
Change subject: KUDU-3326 [master] add flag FLAGS_enable_soft_delete_on_master to enable soft-delete on master ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/18864/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS3: Could you please add tests to check how does it act when use the new added client APIs (i.e. SoftDeleteTable, RecallTable) to operate on the cluster when FLAGS_enable_soft_delete_on_master is false? http://gerrit.cloudera.org:8080/#/c/18864/3/src/kudu/client/client-test.cc@5218 PS3, Line 5218: TestReserveSecondsofSoftDeleteEnableOnMaster nit: TestReserveSecondsOfSoftDeleteEnableOnMaster http://gerrit.cloudera.org:8080/#/c/18864/3/src/kudu/client/client-test.cc@5247 PS3, Line 5247: SleepFor(MonoDelta::FromMilliseconds(1000 * 60)); This will cause the test last too long time, it doesn't obey the rule in https://kudu.apache.org/docs/contributing.html#_testing. Could you reduce the reserve time, maybe the soft deleted table check interval on master should also to be reduced. http://gerrit.cloudera.org:8080/#/c/18864/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18864/3/src/kudu/master/catalog_manager.cc@413 PS3, Line 413: "NOTE : it's useless if HMS is enable." How about use GROUP_FLAG_VALIDATOR to check it? -- To view, visit http://gerrit.cloudera.org:8080/18864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cf3021fa0e9a425d5f8091ea3336c55a3c14bbc Gerrit-Change-Number: 18864 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 27 Aug 2022 09:16:07 +0000 Gerrit-HasComments: Yes
