Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] KUDU-3389 rafact auto-rebalancer periodic tasks using SchedulerThread ...................................................................... Patch Set 34: (1 comment) http://gerrit.cloudera.org:8080/#/c/18679/34/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/18679/34/src/kudu/master/catalog_manager.h@1355 PS34, Line 1355: td::unique_ptr<ThreadPool> scheduler_pool_; > Yes, that's ok. What's the benefit of using the scheduler thread? I don't see many, but maybe I'm missing something. As for the drawbacks for this particular case that's about creating an extra pool. Is it worth it? -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 34 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 29 Aug 2022 18:21:57 +0000 Gerrit-HasComments: Yes
