Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] KUDU-3389 support turning on/off auto rebalancer at runtime ...................................................................... Patch Set 31: (4 comments) http://gerrit.cloudera.org:8080/#/c/18679/31//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18679/31//COMMIT_MSG@14 PS31, Line 14: There are many independent, idle and isolated threads(which do : period tasks), they don't participant in thread pool. This patch also : optimizes it to use less threads, unified thread pool to manager them. I don't understand what these threads are. Before this patch we only have one thread for the auto rebalance task, right? Please make it clear what exactly the optimization is. http://gerrit.cloudera.org:8080/#/c/18679/31/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/18679/31/src/kudu/master/catalog_manager.h@1260 PS31, Line 1260: Auto rebalancer uses the thread pool to run periodic tasks. Will it be used to run only rebalance tasks in the future? http://gerrit.cloudera.org:8080/#/c/18679/31/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18679/31/src/kudu/master/catalog_manager.cc@160 PS31, Line 160: DEFINE_int32(scheduler_pool_max_thread_num, 4, "max thread numbers of scheduler thread pool"); Does it mean we can have 4 concurrent rebalance tasks at most? And why the default value is 4? Maybe it's worth describing it more. http://gerrit.cloudera.org:8080/#/c/18679/31/src/kudu/master/catalog_manager.cc@1645 PS31, Line 1645: if (scheduler_pool_) { : scheduler_pool_->Shutdown(); : } : : if (auto_rebalancer_) { : auto_rebalancer_->Shutdown(); : } Should we call auto_rebalancer_->Shutdown() before calling scheduler_pool_->Shutdown()?Since the auto_rebalancer_ will submit tasks to the thread pool. -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 31 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 12 Aug 2022 03:36:44 +0000 Gerrit-HasComments: Yes
