Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu cpp client bug when using replica_selection policy ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18877/5/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/5/src/kudu/client/scan_token-test.cc@1607 PS5, Line 1607: // KuduClient::ReplicaSelection::CLOSEST_REPLICA Can you also add tests for the new field FIRST_REPLICA? http://gerrit.cloudera.org:8080/#/c/18877/5/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18877/5/src/kudu/common/common.proto@315 PS5, Line 315: FIRST_REPLIC nit: add a note about this new field in the commit message -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 5 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 22:16:59 +0000 Gerrit-HasComments: Yes
