Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu cpp client bug when using replica_selection policy ...................................................................... Patch Set 7: (2 comments) Thanks for your help, your crs and your time. http://gerrit.cloudera.org:8080/#/c/18877/5/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/5/src/kudu/client/scan_token-test.cc@1607 PS5, Line 1607: vector<KuduScanToken*> tokens; > Can you also add tests for the new field FIRST_REPLICA? OK. done http://gerrit.cloudera.org:8080/#/c/18877/5/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18877/5/src/kudu/common/common.proto@315 PS5, Line 315: // The repli > nit: add a note about this new field in the commit message ok. Because cpp client support this. But java not support it. So adding the replica selection strategy to adapt existing test cases. I think the strategy may not be significant for users, only used at cpp client and some CLI tools. -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 7 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 31 Aug 2022 15:18:06 +0000 Gerrit-HasComments: Yes
