KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18864 )
Change subject: KUDU-3326 [master] add flag FLAGS_deleted_table_reserve_seconds to change the cluster-wide behavior of the DeleteTable() RPC. ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/18864/14/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18864/14/src/kudu/master/catalog_manager.cc@2422 PS14, Line 2422: eq, > Ah, indeed. That's a bit strange that the same condition on FLAGS_deleted_ Done http://gerrit.cloudera.org:8080/#/c/18864/14/src/kudu/master/catalog_manager.cc@2421 PS14, Line 2421: if (FLAGS_deleted_table_reserve_seconds == 0 || is_soft_deleted_table) { : return DeleteTableRpc(req, resp, rpc); : } > I'm not sure I understand that explanation. Yes, I added the test case you mentioned and found that I need to modify the code. Could you help ti check this again? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cf3021fa0e9a425d5f8091ea3336c55a3c14bbc Gerrit-Change-Number: 18864 Gerrit-PatchSet: 15 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 08 Sep 2022 06:40:19 +0000 Gerrit-HasComments: Yes
