KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18864 )
Change subject: KUDU-3326 [master] add flag FLAGS_deleted_table_reserve_seconds to change the cluster-wide behavior of the DeleteTable() RPC. ...................................................................... Patch Set 17: (8 comments) http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/client/client-test.cc@5221 PS17, Line 5221: ASSERT_FALSE(FLAGS_deleted_table_reserve_seconds); > nit for here and below: please replace with ASSERT_EQ(0, FLAGS_deleted_tabl Done http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/client/client-test.cc@5222 PS17, Line 5222: = 1; > To prevent flakiness in case of scheduler anomalies and/or slow inferior te I used to set this 60, but Yingchun Lai suggest to obey the rule in https://kudu.apache.org/docs/contributing.html#_testing. http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/client/client-test.cc@5242 PS17, Line 5242: ASSERT_EQ(0, tables.size()); > nit: if using ASSERT_TRUE(tables.empty()) at line 5251, maybe use it here a Done http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/client/client-test.cc@5258 PS17, Line 5258: ASSERT_FALSE(FLAGS_deleted_table_reserve_seconds); > nit: please replace with ASSERT_EQ(0, FLAGS_deleted_table_reserve_seconds) Done http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/client/client-test.cc@5261 PS17, Line 5261: // Delete the table, the table won't be purged immediately if : // FLAGS_deleted_table_reserve_seconds set to anything greater than 0. > Is this relevant if non-zero 'reserve_seconds' comes with DeleteTableReques Removed. http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/client/client-test.cc@5279 PS17, Line 5279: ASSERT_EQ(0, tables.size()); > nit: if using ASSERT_TRUE(tables.empty()) at line 5288, maybe use it here a Done http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/master/catalog_manager.cc@413 PS17, Line 413: > nit: remove the extra space Done http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/master/catalog_manager.cc@2419 PS17, Line 2419: // Reserve seconds equal 0 means delete it directly. : if (req.reserve_seconds() == 0 && : (FLAGS_deleted_table_reserve_seconds == 0 || is_soft_deleted_table)) { : return DeleteTableRpc(req, resp, rpc); : } > One comment which is a bit off-topic (or just a broader note). It's not ne Yes, you put forward a very good improvement point. I am very happy to propose a new patch to realize your idea. Thank you very much for your advice! -- To view, visit http://gerrit.cloudera.org:8080/18864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cf3021fa0e9a425d5f8091ea3336c55a3c14bbc Gerrit-Change-Number: 18864 Gerrit-PatchSet: 17 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 15 Sep 2022 07:46:49 +0000 Gerrit-HasComments: Yes
