Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/18965 )
Change subject: [cfile] unsorted updates on cfile_reader.{h,cc}
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18965/2/src/kudu/cfile/cfile_reader.h
File src/kudu/cfile/cfile_reader.h:
http://gerrit.cloudera.org:8080/#/c/18965/2/src/kudu/cfile/cfile_reader.h@190
PS2, Line 190: const Slice& checksum);
> nit: alignment
The alignment looks correct per the style guide: the parameters are aligned
with the opening parenthesis, see the 'If you have too much text to fit on one
line' case at
https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
http://gerrit.cloudera.org:8080/#/c/18965/2/src/kudu/cfile/cfile_reader.cc
File src/kudu/cfile/cfile_reader.cc:
http://gerrit.cloudera.org:8080/#/c/18965/2/src/kudu/cfile/cfile_reader.cc@450
PS2, Line 450: ptr.ToString(),
file_size_));
> not: alignment?
The indentation and the alignment seems legit per
https://google.github.io/styleguide/cppguide.html#Function_Calls
--
To view, visit http://gerrit.cloudera.org:8080/18965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25507963f87e08a6c3a8ba2ff1ca58836b713e18
Gerrit-Change-Number: 18965
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Sun, 11 Sep 2022 16:26:07 +0000
Gerrit-HasComments: Yes
