Yifan Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/18965 )
Change subject: [cfile] unsorted updates on cfile_reader.{h,cc}
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18965/3/src/kudu/cfile/cfile_reader.h
File src/kudu/cfile/cfile_reader.h:
http://gerrit.cloudera.org:8080/#/c/18965/3/src/kudu/cfile/cfile_reader.h@186
PS3, Line 186: ;
> This method became static, so 'const' isn't applicable.
Ah indeed, thanks for your explanation!
--
To view, visit http://gerrit.cloudera.org:8080/18965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25507963f87e08a6c3a8ba2ff1ca58836b713e18
Gerrit-Change-Number: 18965
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 14 Sep 2022 07:13:45 +0000
Gerrit-HasComments: Yes
