Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18835 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 2) ...................................................................... Patch Set 14: Verified+1 (5 comments) Overall looks good to me, just a few nits to address. Thanks! http://gerrit.cloudera.org:8080/#/c/18835/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18835/14//COMMIT_MSG@12 PS14, Line 12: 1. A new KuduColumnSpec::Immutable() method to add the attribute : to a column. nit: maybe, also add a note about the newly added KuduColumnSpec::Mutable() method http://gerrit.cloudera.org:8080/#/c/18835/12/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18835/12/src/kudu/client/client-test.cc@506 PS12, Line 506: > Reasonable, and I also make some other functions as const. Thanks! http://gerrit.cloudera.org:8080/#/c/18835/12/src/kudu/client/client-test.cc@3076 PS12, Line 3076: ; > It's related to a previous implemention, I've reverted it to AUTO_FLUSH_SYN OK, that makes sense. http://gerrit.cloudera.org:8080/#/c/18835/14/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18835/14/src/kudu/client/client-test.cc@240 PS14, Line 240: void nit: does it make sense to make this method return Status and then add ASSERT_OK() at its call sites? http://gerrit.cloudera.org:8080/#/c/18835/14/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/18835/14/src/kudu/client/schema.h@509 PS14, Line 509: Set the column to be mutable. nit: please add a notion that's this the default state for a column (something similar to Nullable) -- To view, visit http://gerrit.cloudera.org:8080/18835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id301e313eedd9cc3a494d6b4f3c14fbabe63b436 Gerrit-Change-Number: 18835 Gerrit-PatchSet: 14 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 12 Sep 2022 05:23:40 +0000 Gerrit-HasComments: Yes
