Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18835 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 2) ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/18835/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18835/14//COMMIT_MSG@12 PS14, Line 12: 1. New KuduColumnSpec::Immutable() and KuduColumnSpec::Mutable() : methods to a > nit: maybe, also add a note about the newly added KuduColumnSpec::Mutable() Done http://gerrit.cloudera.org:8080/#/c/18835/14/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18835/14/src/kudu/client/client-test.cc@240 PS14, Line 240: Stat > nit: does it make sense to make this method return Status and then add ASSE Done -- To view, visit http://gerrit.cloudera.org:8080/18835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id301e313eedd9cc3a494d6b4f3c14fbabe63b436 Gerrit-Change-Number: 18835 Gerrit-PatchSet: 15 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 13 Sep 2022 01:01:09 +0000 Gerrit-HasComments: Yes
