Yifan Zhang has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/18965 )
Change subject: [cfile] unsorted updates on cfile_reader.{h,cc}
......................................................................
[cfile] unsorted updates on cfile_reader.{h,cc}
This patch makes the code in cfile_reader.{h,cc} a bit more robust:
* check more rigorously for invariants to protect against unsigned
integer underflow, etc.
* don't crash but instead return Status::Corruption() when possible
* optimized the check on whether to verify checksums
* added 'final' to CFileIterator and DefaultColumnValueIterator
classes to provide more de-virtualisation opportunities for compiler
* added PREDICT_{FALSE,TRUE} where appropriate
* added the 'runtime' tag for the --cfile_verify_checksums flag
* other minor updates
Change-Id: I25507963f87e08a6c3a8ba2ff1ca58836b713e18
Reviewed-on: http://gerrit.cloudera.org:8080/18965
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
Reviewed-by: Yifan Zhang <[email protected]>
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
2 files changed, 101 insertions(+), 71 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, but someone else must approve
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I25507963f87e08a6c3a8ba2ff1ca58836b713e18
Gerrit-Change-Number: 18965
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
