Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18971 )
Change subject: [macos] Add sample to PstackWatcher ...................................................................... Patch Set 2: (5 comments) I just took a quick first look. http://gerrit.cloudera.org:8080/#/c/18971/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18971/2//COMMIT_MSG@9 PS2, Line 9: None of : the utilized tools (gdb, pstack, gstack) work on Apple Silicon Wasn't that just for macOS in general, regardless of the CPU architecture? http://gerrit.cloudera.org:8080/#/c/18971/2//COMMIT_MSG@12 PS2, Line 12: ‘sample’ is : an OSX specific command-line tool, which can collect call stacks of all : threads in a process Did you consider using 'lldb' instead? At least, there is quite straightforward conversion between most of gdb and lldb commands, so maybe it would be easier to port PstackWatcher::RunGdbStackDump() http://gerrit.cloudera.org:8080/#/c/18971/2//COMMIT_MSG@17 PS2, Line 17: I tested it on my M1 MacBook Pro. Could you add an example of the output produced with this patch for, say, the failure you mention in memory_gc-itest? http://gerrit.cloudera.org:8080/#/c/18971/2//COMMIT_MSG@19 PS2, Line 19: the memory_gc-itest, which was : failing on my Mac Just for your reference: that test passes on my laptop running macOS BigSur 11.7 (20G817) http://gerrit.cloudera.org:8080/#/c/18971/2//COMMIT_MSG@22 PS2, Line 22: Using this patch the test still fails, however now I : obtain a proper call stack dump, which enables future work. BTW, if you are interested in another workaround to get proper stacks and maybe even an access to a debugging session for closer introspection, update the test to use InternalMiniCluster instead of the ExtrnalMiniCluster (yes, those tablet servers will have the same setting for --gc_tcmalloc_memory_interval_seconds then) and run it under the debugger (lldb is great for that), maybe even adding the '--gtest_break_on_failure' flag. -- To view, visit http://gerrit.cloudera.org:8080/18971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59cea0e8dc99ceb00901f13805a43ec4f11d0a64 Gerrit-Change-Number: 18971 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 14 Sep 2022 22:09:39 +0000 Gerrit-HasComments: Yes
