Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18971 )
Change subject: [macos] Add sample to PstackWatcher ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Thank you for the contribution! http://gerrit.cloudera.org:8080/#/c/18971/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18971/2//COMMIT_MSG@12 PS2, Line 12: s, one can : call: ‘sample $PID 0’. This patch adds sample to PstackWatcher. With : sample added, the Ps > Before deciding on sample, I tried to make lldb work. I haven't looked at this yet, but hope to do so. As for the scope of this patch, I using 'sample' is a good alternative, especially given the fact you've gotten a success story of using it :) http://gerrit.cloudera.org:8080/#/c/18971/2//COMMIT_MSG@17 PS2, Line 17: stigation has been the memory_gc- > Absolutely! Since the dumps are big, I uploaded them externally for you to Thank you! -- To view, visit http://gerrit.cloudera.org:8080/18971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59cea0e8dc99ceb00901f13805a43ec4f11d0a64 Gerrit-Change-Number: 18971 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 27 Sep 2022 09:07:03 +0000 Gerrit-HasComments: Yes
