Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18867

to look at the new patch set (#15).

Change subject: [threadpool] Fix unsafe behaviour when SchedulerThread shutdown
......................................................................

[threadpool] Fix unsafe behaviour when SchedulerThread shutdown

When shutdown thread pool with SchedulerThread, thread pool's variable
'scheduler_' is deleted and 'scheduler_' = nullptr, at the same time,
thread pool token not shutdowned and schedule a task, this may cause
a coredump because of 'scheduler_' = nullptr.

This patch fix the bug, adding a mutex lock in class 'ThreadPool' to
protect variable 'scheduler_'.

Change-Id: I021422f7e51e1007c5bdbc877ab445f70ba12357
---
M src/kudu/util/threadpool-test.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
3 files changed, 97 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/18867/15
--
To view, visit http://gerrit.cloudera.org:8080/18867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I021422f7e51e1007c5bdbc877ab445f70ba12357
Gerrit-Change-Number: 18867
Gerrit-PatchSet: 15
Gerrit-Owner: Yuqi Du <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>

Reply via email to