Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18867 )
Change subject: [threadpool] Fix unsafe behaviour when SchedulerThread shutdown ...................................................................... Patch Set 15: (7 comments) http://gerrit.cloudera.org:8080/#/c/18867/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18867/15//COMMIT_MSG@10 PS15, Line 10: 'scheduler_' = ni: set to http://gerrit.cloudera.org:8080/#/c/18867/15//COMMIT_MSG@11 PS15, Line 11: thread if thread http://gerrit.cloudera.org:8080/#/c/18867/15//COMMIT_MSG@11 PS15, Line 11: not shutdowned is not shutdown http://gerrit.cloudera.org:8080/#/c/18867/15//COMMIT_MSG@12 PS15, Line 12: of 'scheduler_' = scheduler_ is a http://gerrit.cloudera.org:8080/#/c/18867/15/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/18867/15/src/kudu/util/threadpool-test.cc@184 PS15, Line 184: time_t current_time = time(nullptr); How about use class Random to generate random data, the test may run very fast that `current_time` may be the same. http://gerrit.cloudera.org:8080/#/c/18867/15/src/kudu/util/threadpool-test.cc@204 PS15, Line 204: SleepFor(MonoDelta::FromMilliseconds(5)); It it used to ensure the test can be finished safetly, what will happen if removing it? http://gerrit.cloudera.org:8080/#/c/18867/15/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/18867/15/src/kudu/util/threadpool.cc@538 PS15, Line 538: is shutdown nit: has been shutdown? -- To view, visit http://gerrit.cloudera.org:8080/18867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I021422f7e51e1007c5bdbc877ab445f70ba12357 Gerrit-Change-Number: 18867 Gerrit-PatchSet: 15 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 21 Sep 2022 17:03:26 +0000 Gerrit-HasComments: Yes
